feat: sign proposal #858
Merged
feat: sign proposal #858
+91
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sdbondi
reviewed
Jan 3, 2024
| @@ -42,6 +42,30 @@ pub fn check_proposed_by_leader<TAddr: DerivableFromPublicKey, TLeaderStrategy: | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn check_signature(candidate_block: &Block) -> Result<(), ProposalValidationError> { | |||
| if candidate_block.is_dummy() { | |||
There was a problem hiding this comment.
I think we should change the sync to never send and receive dummy blocks, We could calculate dummy blocks instead.
sdbondi
added a commit
to Cifko/tari-dan
that referenced
this pull request
Jan 3, 2024
* development: feat: sign proposal (tari-project#858) feat(template_lib): add from_str for NFT addresses (tari-project#855) chore(engine): remove unused NFT marketplace POC template (tari-project#854) chore(deps): bump unsafe-libyaml from 0.2.9 to 0.2.10 (tari-project#856) fix: clippies on latest stable rust 1.75 (tari-project#862) chore: publish wasm dependencies to crates (tari-project#778) feat: create get_non_fungible_ids action for buckets (tari-project#847) feat(template_test_tooling): include account_nft builtin template (tari-project#850) v0.3.1 chore(deps): bump actions/upload-artifact from 3 to 4 (tari-project#852) chore(deps): bump actions/download-artifact from 3 to 4 (tari-project#851) fix(p2p/messaging): single stream per connection (tari-project#845) feat(p2p): peer-sync protocol (tari-project#844) chore(deps): Bump zerocopy from 0.7.30 to 0.7.31 (tari-project#846)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sing the proposal (the proposer signs the block).
Motivation and Context
How Has This Been Tested?
I just did sample run on dan-testing.
What process can a PR reviewer use to test or verify this change?
You can run the dan-testing and maybe do a debug logs on the signature check to make sure that the checks are enforced.
Breaking Changes